Skip to content

Conversation

@tuj
Copy link
Contributor

@tuj tuj commented Apr 11, 2025

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/4261

Description

Added close preview button to full screen preview.

Screenshot of the result

Screenshot 2025-04-11 at 10 27 23

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

@tuj tuj added the bug Something isn't working label Apr 11, 2025
@tuj tuj requested a review from sinejespersen April 11, 2025 08:27
@tuj tuj self-assigned this Apr 11, 2025
@sinejespersen
Copy link
Contributor

hahaha great picture

image

className="preview-overlay d-flex justify-content-center align-items-center flex-column"
>
<Button
id="close_preview_button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="close_preview_button"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think the id is used

className="preview-overlay d-flex justify-content-center align-items-center flex-column"
>
<Button
id="close_preview_button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="close_preview_button"

variant="info"
className="mt-3"
<Button
id="close_preview_button"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
id="close_preview_button"

Copy link
Contributor

@sinejespersen sinejespersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding standards

@tuj tuj requested a review from sinejespersen April 11, 2025 09:21
@tuj tuj merged commit 31dae10 into develop Apr 11, 2025
4 checks passed
@tuj tuj deleted the feature/preview-fixes branch April 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants