Fixed preview spacing and added preview border #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yepzdk
previously approved these changes
Apr 14, 2025
Contributor
yepzdk
left a comment
yepzdk
left a comment
There was a problem hiding this comment.
A couple of comments to improve consistency.
But otherwise good work.
| .remote-component-wrapper { | ||
| width: 100%; | ||
| height: 100%; | ||
| box-shadow: 0 0 1px #aaa; |
Contributor
There was a problem hiding this comment.
I think you could consider user border here.
Otherwise consider using a shadow like in https://github.com/os2display/display-templates/blob/898d24d1ee6b63e8ff5c2caa99bfd02e02162cea/src/global-styles.css#L130
src/components/preview/preview.jsx
Outdated
| width: `${width}px`, | ||
| height: `${height}px`, | ||
| overflow: "hidden", | ||
| boxShadow: "0 0 1px #aaa", |
Contributor
There was a problem hiding this comment.
Maybe this should reuse the styling from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/#/tickets/showTicket/4261
Description
Fixed preview spacing and added preview border.
Checklist