Skip to content

Conversation

@turegjorup
Copy link
Contributor

@turegjorup turegjorup commented Dec 5, 2024

Link to ticket

https://leantime.itkdev.dk/#/tickets/showTicket/2533

Description

  • Implement new feed type for Colibo API
  • Refactor feed type structure
  • Started general feed structure documentation

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

Related PRs

@tuj tuj added the enhancement New feature or request label Dec 10, 2024
@tuj tuj changed the title Feature/2533 colibo feed type Colibo feed type Dec 18, 2024
@tuj tuj removed their request for review December 18, 2024 09:19
@tuj tuj marked this pull request as ready for review December 19, 2024 16:13
@tuj tuj requested a review from sinejespersen December 19, 2024 16:13
booking system you can implement a "FeedSource" that fetches booking data from your source and normalizes it to match
the calendar output model.

@todo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo what?

{
$feedEntryRecipients = $this->feedService->getFeedSourceConfigUrl($feedSource, 'allowed-recipients');

return [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAdminFormOptions returns the admin options for the given feed type in the form of an array of array elements.

@tuj tuj requested a review from sinejespersen December 20, 2024 10:15
$cacheItem = $this->feedsCache->getItem($feedId);

if ($cacheItem->isHit()) {
if (false && $cacheItem->isHit()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

{
$feedEntryRecipients = $this->feedService->getFeedSourceConfigUrl($feedSource, 'allowed-recipients');

return [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAdminFormOptions returns the admin options for the given feed type in the form of an array of array elements.

@turegjorup turegjorup merged commit a130ffa into develop Apr 7, 2025
13 checks passed
@turegjorup turegjorup deleted the feature/2533_colibo_feed_type branch April 7, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants