Changed how exceptions are handled in InstantBook

CHANGELOG.md

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+- [#260](https://github.com/os2display/display-api-service/pull/260)
+  - Changed how exceptions are handled in InstantBook.
+
 ## [2.5.1] - 2025-06-23
 
 - [#245](https://github.com/os2display/display-api-service/pull/245)

src/Controller/InteractiveController.php

@@ -7,12 +7,14 @@
 use App\Entity\ScreenUser;
 use App\Entity\Tenant\Slide;
 use App\Entity\User;
-use App\Exceptions\NotFoundException;
+use App\Exceptions\InteractiveSlideException;
 use App\Service\InteractiveSlideService;
 use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Attribute\AsController;
+use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 #[AsController]
 final readonly class InteractiveController
@@ -26,14 +28,24 @@ public function __invoke(Request $request, Slide $slide): JsonResponse
     {
         $requestBody = $request->toArray();
 
-        $interactionRequest = $this->interactiveSlideService->parseRequestBody($requestBody);
+        try {
+            $interactionRequest = $this->interactiveSlideService->parseRequestBody($requestBody);
+        } catch (InteractiveSlideException $e) {
+            throw new HttpException($e->getCode(), $e->getMessage());
+        }
 
         $user = $this->security->getUser();
 
         if (!($user instanceof User || $user instanceof ScreenUser)) {
-            throw new NotFoundException('User not found');
+            throw new NotFoundHttpException('User not found');
+        }
+
+        try {
+            $actionResult = $this->interactiveSlideService->performAction($user, $slide, $interactionRequest);
+        } catch (InteractiveSlideException $e) {
+            throw new HttpException($e->getCode(), $e->getMessage());
         }
 
-        return new JsonResponse($this->interactiveSlideService->performAction($user, $slide, $interactionRequest));
+        return new JsonResponse($actionResult);
     }
 }