wip: (mostly) useimages library to generate bootc disks #1009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves to images v0.166.0
With that we can compare manifests between bib and images, e.g. ``` $ go build && sudo IMAGE_BUILDER_EXPERIMENTAL=bib-mock-resolvers ./bootc-image-builder manifest -v --type qcow2 quay.io/centos-bootc/centos-bootc:stream9 |jq > bootc_centos_9-x86_64-qcow2-bootc_empty.json && diff -u bootc_centos_9-x86_64-qcow2-bootc_empty.json /tmp/new/bootc_centos_9-x86_64-qcow2-bootc_empty.json ``` to see the difference between bib and images for the same container.
Add a `gen-manifests` helper that creates mock manifests from the given image type. Its not perfect mocks as it still will look into the bootc ref (centos9). Its not generating checksums only because to compare from the manifests generated by bib and images its easier to work with full manifests and we only have very few of them in bib.
Unlike images which has tons of manifests we only have a few and when we do cross images<->bib manifest diff having them in git will be useful.
…mvo5/images@50744ebf2e6bce9a2a5f9108e1173ff695f0579b to get latest bib-images-convergence-disk-only-for-now branch
|
Closing in favor of #1014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP branch that shows porting bib to use the images library for manifest generation.