Skip to content

bib: simplify manifestFromCobraForLegacyISO #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

bib: simplify manifestFromCobraForLegacyISO #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
63c2d6f
go.mod: update images to v0.214.0
mvo5 Oct 28, 2025
018dc9d
many: drop custom `distrodefs` and use images DistroYAML
mvo5 Oct 6, 2025
09d266f
bib: add support for ID_LIKE when finding the distro YAML
mvo5 Oct 28, 2025
006d4a0
bib: use `images` library for shared bootc helpers
mvo5 Oct 29, 2025
848ef51
bib: drop no-longer used NullWorkload
mvo5 Oct 29, 2025
b8c30c3
bib: drop no longer needed ManifestConfig.DistroDefPaths
mvo5 Nov 5, 2025
6f6e208
bib: use bootc.PlatformFor() to get ISO platform
mvo5 Nov 5, 2025
bf74f48
bib: use imgType.Filename to determine the filename
mvo5 Nov 5, 2025
5a253a1
wip
mvo5 Nov 5, 2025
5dd11fa
bib: simplify manifestFromCobraForLegacyISO
mvo5 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ COPY ./group_osbuild-osbuild-fedora.repo /etc/yum.repos.d/
COPY ./package-requires.txt .
RUN grep -vE '^#' package-requires.txt | xargs dnf install -y && rm -f package-requires.txt && dnf clean all
COPY --from=builder /build/bin/* /usr/bin/
COPY bib/data /usr/share/bootc-image-builder

ENTRYPOINT ["/usr/bin/bootc-image-builder"]
VOLUME /output
Expand Down
10 changes: 5 additions & 5 deletions bib/cmd/bootc-image-builder/export_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import (
)

var (
CanChownInPath = canChownInPath
GetDistroAndRunner = getDistroAndRunner
CreateRand = createRand
BuildCobraCmdline = buildCobraCmdline
HandleAWSFlags = handleAWSFlags
CanChownInPath = canChownInPath
CreateRand = createRand
BuildCobraCmdline = buildCobraCmdline
HandleAWSFlags = handleAWSFlags
NewDistroYAMLFrom = newDistroYAMLFrom
)

func MockOsGetuid(new func() int) (restore func()) {
Expand Down
58 changes: 0 additions & 58 deletions bib/cmd/bootc-image-builder/image_test.go
View file
Open in desktop

This file was deleted.

Loading
Loading