Remove AWS region cloning support (HMS-9604) #1754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochosi
force-pushed
the
drop-aws-cloning
branch
from
b5b4b86 to
d30c650
Compare
Contributor
Author
|
The frontend PR first needs to be merged. |
Remove the clone endpoints and related functionality:
- Remove /composes/{composeId}/clone, /composes/{composeId}/clones, and
/clones/{id} API endpoints from OpenAPI spec and regenerate api.go
- Remove CloneCompose, GetCloneStatus, GetComposeClones handlers
- Remove clone-related DB interface methods (InsertClone, GetClonesForCompose,
GetClone) and SQL queries
- Remove CloneCompose and CloneStatus methods from composer client
- Remove clone-related tests from handler_test.go and main_test.go
- Add migration to drop the clones table
The clone feature allowed copying AWS AMIs to other regions, but this
functionality is being removed in favor of direct uploads to the desired region.
ochosi
force-pushed
the
drop-aws-cloning
branch
from
d30c650 to
64d0417
Compare
Contributor
Author
|
We may want to let the frontend changes sit a week or so before we drop this from the backend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the clone endpoints and related functionality:
The clone feature allowed copying AWS AMIs to other regions, but this functionality is being removed in favor of direct uploads to the desired region.
This is the backend change relating to osbuild/image-builder-frontend#4018