split out dev checks (HMS-8754)#3372
Conversation
kingsleyzissou
force-pushed
the
pr-checks
branch
11 times, most recently
from
6d7235a to
af88f67
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #3372 +/- ##
=======================================
Coverage 84.60% 84.60%
=======================================
Files 188 188
Lines 23614 23614
Branches 2451 2452 +1
=======================================
Hits 19978 19978
Misses 3620 3620
Partials 16 16 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
kingsleyzissou
force-pushed
the
pr-checks
branch
10 times, most recently
from
cd8b622 to
d3ce725
Compare
kingsleyzissou
force-pushed
the
pr-checks
branch
from
d3ce725 to
749f6a6
Compare
Split out the unit tests into their own action. This decouples the unit tests from the other tests. This means the gitlab schutzbot tests don't have to wait until the unit tests are completed before they are triggered. This also a step towards splitting out the tests so it is more obvious to see which step is failing and why.
kingsleyzissou
force-pushed
the
pr-checks
branch
from
749f6a6 to
7039343
Compare
|
We'll need to remove the |
.github/workflows/dev-checks.yml
Outdated
| run: npm run build | ||
|
|
||
| lint-checks: | ||
| name: Linting Checks |
There was a problem hiding this comment.
I would maybe consider calling this just Linter, or more specifically which linter it actually is, like ESLint? Seems way less ambiguous to me. 🤔
There was a problem hiding this comment.
For the record, I had to keep the other checks in the same workflow file since it is incredibly difficult trying to trigger the gitlab workflow after multiple workflows have completed
Split out the dev checks into multiple jobs, the benefit of this is that it will be easier to see which check is failing and why.
kingsleyzissou
force-pushed
the
pr-checks
branch
from
7039343 to
393c6fb
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
regexowl
left a comment
regexowl
left a comment
There was a problem hiding this comment.
Nice! Let me update the required checks list and then we can merge 🚀
3 participants
Split out the dev checks into their own actions. The benefit of this is that it makes it clearer what is failing and easier to find out why. It also means we have more control when the gitlab schutzbot tests are triggered.
Fixes: HMS-8754