api: manually update content sources#4238
Merged
regexowl merged 1 commit intoosbuild:mainfrom Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The change from
feature_namestoextended_release_streamsinConfigDistributionMinorVersionand fromextended_release_featurestoextended_release_streamsinApiRepositoryParameterResponseis a breaking shape change; consider adding a compatibility layer or updating all downstream consumers in the same PR to avoid runtime mismatches. - Double-check that the new
ApiExtendedReleaseArchitecture/ApiExtendedReleaseStreamstructures align with the backend API (field names and optionality) and that any code mapping server responses into these types is updated accordingly to prevent undefined fields at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The change from `feature_names` to `extended_release_streams` in `ConfigDistributionMinorVersion` and from `extended_release_features` to `extended_release_streams` in `ApiRepositoryParameterResponse` is a breaking shape change; consider adding a compatibility layer or updating all downstream consumers in the same PR to avoid runtime mismatches.
- Double-check that the new `ApiExtendedReleaseArchitecture` / `ApiExtendedReleaseStream` structures align with the backend API (field names and optionality) and that any code mapping server responses into these types is updated accordingly to prevent undefined fields at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4238 +/- ##
=======================================
Coverage 73.68% 73.68%
=======================================
Files 198 198
Lines 7263 7263
Branches 2690 2691 +1
=======================================
Hits 5352 5352
Misses 1672 1672
Partials 239 239 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
avitova
approved these changes
Mar 26, 2026
Collaborator
|
/retest |
Collaborator
Author
|
Will look into the CI issues tomorrow. Might need manual fixing |
regexowl
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to unblock CI