Skip to content

api: manually update content sources#4238

Merged
regexowl merged 1 commit intoosbuild:mainfrom
kingsleyzissou:fix-api-generation
Mar 27, 2026
Merged

api: manually update content sources#4238
regexowl merged 1 commit intoosbuild:mainfrom
kingsleyzissou:fix-api-generation

Conversation

@kingsleyzissou
Copy link
Copy Markdown
Collaborator

Just to unblock CI

@kingsleyzissou kingsleyzissou requested a review from a team as a code owner March 26, 2026 17:03
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The change from feature_names to extended_release_streams in ConfigDistributionMinorVersion and from extended_release_features to extended_release_streams in ApiRepositoryParameterResponse is a breaking shape change; consider adding a compatibility layer or updating all downstream consumers in the same PR to avoid runtime mismatches.
  • Double-check that the new ApiExtendedReleaseArchitecture / ApiExtendedReleaseStream structures align with the backend API (field names and optionality) and that any code mapping server responses into these types is updated accordingly to prevent undefined fields at runtime.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The change from `feature_names` to `extended_release_streams` in `ConfigDistributionMinorVersion` and from `extended_release_features` to `extended_release_streams` in `ApiRepositoryParameterResponse` is a breaking shape change; consider adding a compatibility layer or updating all downstream consumers in the same PR to avoid runtime mismatches.
- Double-check that the new `ApiExtendedReleaseArchitecture` / `ApiExtendedReleaseStream` structures align with the backend API (field names and optionality) and that any code mapping server responses into these types is updated accordingly to prevent undefined fields at runtime.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.68%. Comparing base (7146b8d) to head (4fafe85).
⚠️ Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4238   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files         198      198           
  Lines        7263     7263           
  Branches     2690     2691    +1     
=======================================
  Hits         5352     5352           
  Misses       1672     1672           
  Partials      239      239           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7146b8d...4fafe85. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingsleyzissou kingsleyzissou added the 🍼 simple Simple and quick to review label Mar 26, 2026
Copy link
Copy Markdown
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mgold1234
Copy link
Copy Markdown
Collaborator

/retest

@kingsleyzissou kingsleyzissou disabled auto-merge March 26, 2026 22:38
@kingsleyzissou
Copy link
Copy Markdown
Collaborator Author

Will look into the CI issues tomorrow. Might need manual fixing

@regexowl regexowl enabled auto-merge March 27, 2026 09:49
@regexowl regexowl added this pull request to the merge queue Mar 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 27, 2026
@regexowl regexowl added this pull request to the merge queue Mar 27, 2026
Merged via the queue into osbuild:main with commit 77f9873 Mar 27, 2026
36 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍼 simple Simple and quick to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants