Skip to content

Wizard: make description of target envs clickable#4264

Merged
kingsleyzissou merged 1 commit intoosbuild:mainfrom
avitova:clickable-descriptions
Apr 2, 2026
Merged

Wizard: make description of target envs clickable#4264
kingsleyzissou merged 1 commit intoosbuild:mainfrom
avitova:clickable-descriptions

Conversation

@avitova
Copy link
Copy Markdown
Collaborator

@avitova avitova commented Apr 1, 2026

This is what I brought up during the UX meeting. :)
Do we have Playwright tests for this step yet? Could not find any.

@avitova avitova requested a review from a team as a code owner April 1, 2026 16:33
@avitova avitova requested review from ksiekl, mgold1234 and regexowl April 1, 2026 16:33
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.54%. Comparing base (8b1ff13) to head (bde581e).
⚠️ Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4264   +/-   ##
=======================================
  Coverage   71.54%   71.54%           
=======================================
  Files         199      199           
  Lines        7524     7524           
  Branches     2813     2813           
=======================================
  Hits         5383     5383           
  Misses       1867     1867           
  Partials      274      274           
Files with missing lines Coverage Δ
...steps/ImageOutput/components/TargetEnvironment.tsx 86.72% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1ff13...bde581e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingsleyzissou kingsleyzissou added this pull request to the merge queue Apr 2, 2026
Merged via the queue into osbuild:main with commit 04e1552 Apr 2, 2026
34 of 36 checks passed
@regexowl
Copy link
Copy Markdown
Collaborator

regexowl commented Apr 2, 2026

@avitova This sounds like good thing to test in the co-located unit tests:
src/Components/CreateImageWizard/steps/ImageOutput/tests/TargetEnvironment.test.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants