Wizard: Update target list to improve visual hierarchy (HMS-10463)#4267
Merged
kingsleyzissou merged 1 commit intoosbuild:mainfrom Apr 2, 2026
Merged
Wizard: Update target list to improve visual hierarchy (HMS-10463)#4267kingsleyzissou merged 1 commit intoosbuild:mainfrom
kingsleyzissou merged 1 commit intoosbuild:mainfrom
Conversation
This updates the list of targets on the Image Output step to make it clearer that the Target environments section included public and private cloud, and misc formats altogether.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4267 +/- ##
=======================================
Coverage 71.52% 71.52%
=======================================
Files 199 199
Lines 7526 7526
Branches 2813 2813
=======================================
Hits 5383 5383
Misses 1869 1869
Partials 274 274
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider removing the redundant
aria-labelprops from the checkboxes where the visiblelabelalready provides equivalent text, as this will simplify the markup and reduce the risk of label/aria-label divergence (for example,Google Cloud PlatformvsGoogle Cloud checkbox). - Now that all checkbox groups share the same
pf-v6-u-mb-sm pf-v6-u-ml-lgpattern and similar props, you might extract a small helper/component to reduce repetition and make future styling or behavior changes easier to apply consistently.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider removing the redundant `aria-label` props from the checkboxes where the visible `label` already provides equivalent text, as this will simplify the markup and reduce the risk of label/aria-label divergence (for example, `Google Cloud Platform` vs `Google Cloud checkbox`).
- Now that all checkbox groups share the same `pf-v6-u-mb-sm pf-v6-u-ml-lg` pattern and similar props, you might extract a small helper/component to reduce repetition and make future styling or behavior changes easier to apply consistently.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
kingsleyzissou
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the list of targets on the Image Output step to make it clearer that the Target environments section included public and private cloud, and misc formats altogether.