Skip to content

Wizard: Update target list to improve visual hierarchy (HMS-10463)#4267

Merged
kingsleyzissou merged 1 commit intoosbuild:mainfrom
regexowl:target-hierarchy
Apr 2, 2026
Merged

Wizard: Update target list to improve visual hierarchy (HMS-10463)#4267
kingsleyzissou merged 1 commit intoosbuild:mainfrom
regexowl:target-hierarchy

Conversation

@regexowl
Copy link
Copy Markdown
Collaborator

@regexowl regexowl commented Apr 2, 2026

This updates the list of targets on the Image Output step to make it clearer that the Target environments section included public and private cloud, and misc formats altogether.

image

This updates the list of targets on the Image Output step to make it clearer that the Target environments section included public and private cloud, and misc formats altogether.
@regexowl regexowl changed the title Wizard: Update target list to improve visual hierarchy Wizard: Update target list to improve visual hierarchy (HMS-10463) Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.52%. Comparing base (a40080d) to head (004c985).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...steps/ImageOutput/components/TargetEnvironment.tsx 94.11% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4267   +/-   ##
=======================================
  Coverage   71.52%   71.52%           
=======================================
  Files         199      199           
  Lines        7526     7526           
  Branches     2813     2813           
=======================================
  Hits         5383     5383           
  Misses       1869     1869           
  Partials      274      274           
Files with missing lines Coverage Δ
...steps/ImageOutput/components/TargetEnvironment.tsx 86.72% <94.11%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40080d...004c985. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regexowl regexowl marked this pull request as ready for review April 2, 2026 12:42
@regexowl regexowl requested a review from a team as a code owner April 2, 2026 12:42
Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider removing the redundant aria-label props from the checkboxes where the visible label already provides equivalent text, as this will simplify the markup and reduce the risk of label/aria-label divergence (for example, Google Cloud Platform vs Google Cloud checkbox).
  • Now that all checkbox groups share the same pf-v6-u-mb-sm pf-v6-u-ml-lg pattern and similar props, you might extract a small helper/component to reduce repetition and make future styling or behavior changes easier to apply consistently.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider removing the redundant `aria-label` props from the checkboxes where the visible `label` already provides equivalent text, as this will simplify the markup and reduce the risk of label/aria-label divergence (for example, `Google Cloud Platform` vs `Google Cloud checkbox`).
- Now that all checkbox groups share the same `pf-v6-u-mb-sm pf-v6-u-ml-lg` pattern and similar props, you might extract a small helper/component to reduce repetition and make future styling or behavior changes easier to apply consistently.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kingsleyzissou kingsleyzissou enabled auto-merge April 2, 2026 15:49
@kingsleyzissou kingsleyzissou added this pull request to the merge queue Apr 2, 2026
Merged via the queue into osbuild:main with commit 3b350e3 Apr 2, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants