Ak96/refactor contributor script again#730
Draft
aaruni96 wants to merge 6 commits intooscar-system:gh-pagesfrom
Draft
Ak96/refactor contributor script again#730aaruni96 wants to merge 6 commits intooscar-system:gh-pagesfrom
aaruni96 wants to merge 6 commits intooscar-system:gh-pagesfrom
Conversation
aaruni96
force-pushed
the
ak96/refactor-contributor-script-again
branch
from
ae3f1f7 to
6abda7e
Compare
fingolfin
reviewed
Jan 13, 2026
Comment on lines
+55
to
+59
| "# This is because people are marked as retired if the update script could not find them in " | ||
| "any repo.\n" | ||
| "# Retired people only have repo information if repo information about them was known when " | ||
| "they were\n" | ||
| "# active (or manually added) by a maintainer.\n\n" |
Member
There was a problem hiding this comment.
This looks really weird. How about using a triple quoted string, and just wrap the lines here as they'll be wrapped in the generated file?
fingolfin
reviewed
Jan 13, 2026
|
|
||
| def process_log_into_aggregate(res: str, repo: str) -> None: | ||
| global summarystring, aggregate #, email_owner, name_owner | ||
| global summarystring, aggregate # email_owner, name_owner |
Member
There was a problem hiding this comment.
Suggested change
| global summarystring, aggregate # email_owner, name_owner | |
| global summarystring, aggregate |
fingolfin
reviewed
Jan 13, 2026
|
|
||
| def _norm_name(s: str) -> str: | ||
| return " ".join((s or "").split()).casefold() | ||
| def find_author_github_nick(email: str, repos: list[str]) -> str: |
Member
There was a problem hiding this comment.
Maybe rename to find_github_username? This is not a "nick" or "nickname", after all.
| return " ".join((s or "").split()).casefold() | ||
| def find_author_github_nick(email: str, repos: list[str]) -> str: | ||
| if not email: | ||
| return "" |
Member
There was a problem hiding this comment.
This used to return None. The value is then passed on to lookup_user which does not seem ready for this change? (I also find None logically cleaner, but that's a matter of taste shrug)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.