Skip to content

Conversation

oscarhiggott
Copy link
Owner

Fixes a bug where boundary edges weren't always handled properly when they were a component of an error. i.e. handle_dem_error was called the same on edges and boundary edges:

} else if (num_component_detectors > 0) {
    // If the previous error in the decomposition had 1 or 2 detectors, we handle it
    handle_dem_error(p, {component->node1, component->node2}, component->observable_indices);

This resulted in an exception if the boundary edge was not already in the graph. Also refactors related logic slightly.

@oscarhiggott oscarhiggott requested a review from smadhuk September 5, 2025 21:54
Copy link
Collaborator

@smadhuk smadhuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants