This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Implement mount, umount for basic testcases#21
Merged
Azure-stars merged 7 commits intooscomp:mainfrom Mar 24, 2025
Merged
Conversation
Azure-stars
reviewed
Mar 22, 2025
| use core::ffi::{c_char, c_void}; | ||
|
|
||
| pub(crate) fn sys_mount( | ||
| source: *const c_char, |
Collaborator
There was a problem hiding this comment.
Please use UserPtr struct to wrap the raw pointer passed from user mode
| /// check if a path is mounted | ||
| pub fn check_mounted(path: &FilePath) -> bool { | ||
| let mounted = MOUNTED.lock(); | ||
| for m in mounted.iter() { |
Collaborator
There was a problem hiding this comment.
You can simplify it by rewriting it as
mounted.iter().any(|m| path.starts_with(&m.mnt_dir()))
.tap(|is_mounted| {
if is_mounted {
debug!("{} is mounted", path.as_str());
}
})| pub fn umount_fat_fs(mount_path: &FilePath) -> bool { | ||
| let mut mounted = MOUNTED.lock(); | ||
| let mut i = 0; | ||
| while i < mounted.len() { |
Collaborator
There was a problem hiding this comment.
Maybe you can use filter or retain method for iterator to simplify this code
| ); | ||
| return true; | ||
| } | ||
| // } |
Collaborator
There was a problem hiding this comment.
Remove useless comment
| Ok(0) | ||
| } | ||
|
|
||
| pub(crate) fn sys_umount2(target: *const c_char, flags: i32) -> LinuxResult<isize> { |
Collaborator
There was a problem hiding this comment.
Don't add (crate) scope, use pub fn
Azure-stars
reviewed
Mar 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.