fix: fix the nightmode not working problems#1633
Merged
Bambooin merged 3 commits intoosfans:developfrom Mar 26, 2025
Merged
Conversation
There is a bug when current keyboard is number/symbol etc. When trying to switch to chinese keyboard, current behaviour will not update ascii status. Removed currentAsciiMode as it seems like not used after the change. Also allow keyboard to switch to last locked keyboard when there is no ascii keyboard assigned (numbers, symbols etc.)
FlyingpigNZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #1628
Also fixed inconsistent asciimode and switch to last lock keyboard when there was no ascii keyboard is assigned to current one. i.e. numbers, symbols.