refactor: remove unreachable composition clearing code#1920
Merged
WhiredPlanck merged 1 commit intoosfans:developfrom Jan 25, 2026
Merged
refactor: remove unreachable composition clearing code#1920WhiredPlanck merged 1 commit intoosfans:developfrom
WhiredPlanck merged 1 commit intoosfans:developfrom
Conversation
Remove two pieces of meaningless code in handleCursorUpdate: 1. The first code block with condition `composingText.isNotEmpty() && (statusCached.isComposing || hasMenu)` is effectively unreachable. Even if the condition could be satisfied in rare cases, clearing composition at this point would inevitably cause bugs, so it must remain unreachable. 2. Calling finishComposingText() when `!statusCached.isComposing` is nonsensical, as it attempts to finish composing when there is no composing state. Co-authored-by: WhiredPlanck <whiredplanck@outlook.com>
WhiredPlanck
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove two pieces of meaningless code in handleCursorUpdate:
The first code block with condition
composingText.isNotEmpty() && (statusCached.isComposing || hasMenu)is effectively unreachable. Even if the condition could be satisfied in rare cases, clearing composition at this point would inevitably cause bugs, so it must remain unreachable.Calling finishComposingText() when
!statusCached.isComposingis nonsensical, as it attempts to finish composing when there is no composing state.Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #
Fixes #
Feature
Describe features of this pull request
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info