Skip to content

fix(fasterdata): clearer IOMMU audit message + v1.1.3 + site sync + CI verification#35

Merged
ShawnMcKee merged 4 commits intomasterfrom
fix/iommu-audit-message-grubby
Dec 6, 2025
Merged

fix(fasterdata): clearer IOMMU audit message + v1.1.3 + site sync + CI verification#35
ShawnMcKee merged 4 commits intomasterfrom
fix/iommu-audit-message-grubby

Conversation

@ShawnMcKee
Copy link
Contributor

@ShawnMcKee ShawnMcKee commented Dec 6, 2025

fix(fasterdata): clearer IOMMU audit message + v1.1.3 + site sync + CI verification

Summary:

  • Update the fasterdata-tuning.sh GRUB audit message to recommend the correct GRUB regeneration command depending on the system: prefer grubby (EL9/BLS) or fall back to grub2-mkconfig / update-grub.
  • Bump fasterdata-tuning.sh version to 1.1.3 and sync the script and docs into the site/ copy; update checksums for the updated script.
  • Add a changelog entry under docs/perfsonar/tools_scripts/CHANGELOG.md for 1.1.3.
  • Add CI verification to ensure docs -> site script copies remain in sync and that the .sha256 values match the computed script checksum.
  • Add an autoupdate helper and workflow job to auto-update *.sha256 and scripts.sha256 for changed script files in a PR.

Files changed (high level):

  • docs/perfsonar/tools_scripts/fasterdata-tuning.sh — audit message clarification, version bump to 1.1.3, and small doc updates.
  • docs/perfsonar/tools_scripts/fasterdata-tuning.md — clarify --apply-iommu behavior and remove duplicate bullet.
  • site/perfsonar/tools_scripts/* — synced site copies for script & docs and updated SHA files.
  • docs/perfsonar/tools_scripts/CHANGELOG.md — added a changelog entry for 1.1.3.
  • .github/scripts/verify-site-scripts.sh — updated to allow checking only changed script files in PRs.
  • .github/scripts/autoupdate-scripts-sha.sh — new helper that updates per-script .sha256 and scripts.sha256 for changed script files and commits the change.
  • .github/workflows/verify-site-scripts.yml — CI job to run verification on PRs and master pushes.

Testing performed:

  • Verified bash -n for the updated fasterdata-tuning.sh returned no syntax errors.
  • Verified the computed SHA is correct for fasterdata-tuning.sh and this is reflected in the .sha256 files in docs & site.
  • Ran the verify script locally with a file list to confirm changed-only checks work and display mismatches for other scripts.
  • Validated the autoupdate helper updates *.sha256 for changed files (commits the update back to the branch).

Review checklist & notes for reviewers:

  • Verify audit message clarity: The PR should show grubby for EL9/BLS systems and grub2-mkconfig or update-grub for legacy systems.
  • Verify the --apply-iommu documentation in fasterdata-tuning.md and the doc example for --iommu-args are correct.
  • Confirm PR CI workflow is reasonable: it should only check changed scripts to avoid noise; it blocks PR merges when a changed script differs between docs/site or its SHA doesn’t match.
  • Check the autoupdate-scripts-sha.sh behavior to ensure it updates the sha files and scripts.sha256 and commits them to the PR branch (GITHUB_TOKEN used for permission).

Followups (optional):

  • Expand CI to optionally auto-fix or propose a commit for mismatched site copies if docs changes script content (i.e., update site copy rather than failing the build).
  • Add a pre-commit hook or git template to warn authors about updating fasterdata script files and not updating *.sha256 or site copies.

@ShawnMcKee ShawnMcKee merged commit 7ece24f into master Dec 6, 2025
5 of 8 checks passed
@ShawnMcKee ShawnMcKee deleted the fix/iommu-audit-message-grubby branch December 6, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant