Fix: newline-corrupted JSON in saved state (v1.3.4)#66
Merged
ShawnMcKee merged 2 commits intomasterfrom Dec 16, 2025
Merged
Conversation
…l JSON strings via json_quote to prevent embedded newlines
… and update checksum; add CHANGELOG entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix newline-corrupted JSON in saved-state files.\n\nProblem:\n- Saved states could contain embedded newlines (e.g., tuned active profile), producing multi-line JSON like two-line files and breaking consumers.\n\nFixes:\n- Quote/sanitize all JSON string fields via json_quote (qdisc, NM values, ethtool feature values, CPU governors, metadata)\n- Robust parsing and sanitizing of
tuned-adm activeoutput to ensure a single-line profile name\n- Bump script to v1.3.4 and update checksum\n- Add CHANGELOG entry 1.3.4\n\nValidation steps:\n1. Save a state on an affected host\n2. Check line count:wc -l <state>.jsonshould be 1\n3. Validate JSON:python3 -c 'import json,sys; json.load(open(sys.argv[1]))' <state>.json\n\nCI:\n- Please run Code Quality, Docs validation, and MkDocs deploy after merge\n\nImpact:\n- Ensures saved states are valid single-line JSON, preventing restore/diff failures.