Wildcard match fixes #2321
Merged
Wildcard match fixes #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two or more consecutive * characters were not handled. A fix was on the web site this code comes from. Before calling wildMatch recursively with "str + 1", the code did not check whether *str was zero, in which case the "str + 1" is illegal. This also changes the names of the function parameters which were not consistent in .hpp and .cpp files.
To use our normal naming convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two or more consecutive * characters were not handled. A fix was on the web site this code comes from.
Before calling wildMatch recursively with "str + 1", the code did not check whether *str was zero, in which case the "str + 1" is illegal.
This also changes the names of the function parameters which were not consistent in .hpp and .cpp files.
Also: Rename wildMatch to wild_match for consistency with our naming scheme.