Skip to content

Fix/disable some warnings generated by clang-tidy #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Fix/disable some warnings generated by clang-tidy #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b5a461
Fix clang-tidy complaints about value parameters
joto Apr 28, 2025
31650f2
Disable a warning that's clearly wrong here
joto Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/geom-functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ namespace {

void set_to_same_type(geometry_t *output, geometry_t const &input)
{
// NOLINTNEXTLINE(performance-unnecessary-value-param)
input.visit([&](auto in) { output->set<decltype(in)>(); });
}

Expand Down Expand Up @@ -434,7 +435,7 @@ class split_visitor
{}

template <typename T>
void operator()(T) const
void operator()(T const &) const
{}

// false positive https://github.com/llvm/llvm-project/issues/74738
Expand Down Expand Up @@ -544,8 +545,9 @@ namespace {
* empty, do not add the first point returned by *it.
*/
template <typename ITERATOR>
void add_nodes_to_linestring(linestring_t *linestring, ITERATOR it,
ITERATOR end)
void add_nodes_to_linestring(
linestring_t *linestring, ITERATOR it,
ITERATOR end) // NOLINT(performance-unnecessary-value-param)
{
if (!linestring->empty()) {
assert(it != end);
Expand Down
1 change: 1 addition & 0 deletions src/wildcmp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
*
* Returns if a match was found.
*/
// NOLINTNEXTLINE(misc-use-internal-linkage) Seems there is a bug in the checker
bool wild_match(char const *expr, char const *str) noexcept
{
// Code based on
Expand Down