Consistent naming and type for "Lua class names" #2340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using uppercase, because they are constants * Using the word "CLASS" because it is easier to understand then the generic "name" or the Luaish "metatable" * Using char* not std::string_view, because its simpler use (no .data() needed) This is for all the Lua "classes" that we use in flex config files: * ExpireOutput * Geometry * Locator * OSMObject * Table
joto
force-pushed
the
refactor-class-names
branch
from
e42a9e2 to
e39172c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for all the Lua "classes" that we use in flex config files: