Merged
Conversation
PaddyMc
commented
Apr 8, 2025
| case count < limit: | ||
| kv, err := iterator.KeyValue() | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "no concrete type registered for type URL") { |
This comment has been minimized.
This comment has been minimized.
PaddyMc
commented
Apr 8, 2025
| case count == limit: | ||
| key, err := iterator.Key() | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "no concrete type registered for type URL") { |
Collaborator
Author
There was a problem hiding this comment.
added here as well just incase
PaddyMc
commented
Apr 8, 2025
| } else { | ||
| kv, err := iterator.KeyValue() | ||
| if err != nil { | ||
| if strings.Contains(err.Error(), "no concrete type registered for type URL") { |
Collaborator
Author
There was a problem hiding this comment.
added here as well just incase
crnbarr93
reviewed
Apr 8, 2025
| } | ||
|
|
||
| kv, err := iterator.KeyValue() | ||
| if err != nil { |
There was a problem hiding this comment.
Are we missing the fix here as well? This is called when the key param is provided for pagination afaik
crnbarr93
approved these changes
Apr 8, 2025
nicolaslara
approved these changes
Apr 8, 2025
ValarDragon
approved these changes
Apr 8, 2025
Member
ValarDragon
left a comment
ValarDragon
left a comment
There was a problem hiding this comment.
I reviewed the fix lines, I did not review that they match the original function. The fix lines look correct to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix query:
osmosisd q gov proposals --output json --page-reverseCurrently on mainnet this fails:
osmosisd q gov proposals --output json --page-reverse --node https://rpc.osmosis.zoneThe number of proposals that are ignored is:
855 - 847 = 8
see: https://www.mintscan.io/osmosis/proposals