Conversation
|
@echel0n-HX is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughAdds Galaxy Station wallet support: imports and appends extension and mobile wallet info to the wallet list, overrides mobile URL formatting, and registers two wallet entries in the wallet registry with availability, chain-support checks, lazy installs, logos, and stake/governance URLs. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Registry as Wallet Registry
participant Extension as Galaxy Station Extension
participant Mobile as Galaxy Station Mobile
App->>Registry: Request available wallet / connect
Registry->>Extension: Resolve extension entry (lazy import, window check)
alt extension present
Extension-->>Registry: Provide config (supportsChain, install, logo, urls)
else extension absent
Registry->>Mobile: Resolve mobile entry (lazy import)
Mobile->>Mobile: supportsChain checks allowed chainIds
Mobile->>Mobile: formatNativeUrl encodes wcUri (override)
Mobile-->>Registry: Provide config and formatted connection URL
end
Registry-->>App: Return selected wallet config / connection URL
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/web/config/wallet-registry.ts (1)
365-418: Consider sorting the chain list alphabetically.The mobile wallet configuration is correct, but the
galaxyStationMobileAvailableChainsarray could be sorted alphabetically for better maintainability.Apply this diff to sort the chains:
const galaxyStationMobileAvailableChains: MainnetChainIds[] = [ "akashnet-2", "archway-1", "atomone-1", "bitsong-2b", "carbon-1", "celestia", "cheqd-mainnet-1", "chihuahua-1", "columbus-5", "comdex-1", "cosmoshub-4", "crescent-1", "dydx-mainnet-1", "gravity-bridge-3", "injective-1", "irishub-1", "juno-1", "kaiyo-1", "kava_2222-10", "kichain-2", "lum-network-1", - "mars-1", "mainnet-3", + "mars-1", "migaloo-1", "neutron-1", "noble-1", "osmosis-1", - "ssc-1", "pacific-1", "phoenix-1", "sentinelhub-2", + "ssc-1", "stafihub-1", "stargaze-1", "stride-1", "teritori-1", ];
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/web/package.jsonis excluded by!**/*.jsonpackages/web/public/wallets/galaxy-station.pngis excluded by!**/*.png,!**/*.pngyarn.lockis excluded by!**/yarn.lock,!**/*.lock,!**/*.lock
📒 Files selected for processing (2)
packages/web/config/generate-cosmos-kit-wallet-list.ts(3 hunks)packages/web/config/wallet-registry.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (3)
packages/web/config/generate-cosmos-kit-wallet-list.ts (2)
8-9: LGTM! Galaxy Station wallets correctly imported and added to the wallet list.The Galaxy Station extension and mobile wallets are properly imported and integrated into the
CosmosKitWalletList.Also applies to: 43-44
103-114: LGTM! Mobile wallet URL formatting properly configured.The
formatNativeUrloverride for Galaxy Station mobile wallet correctly implements the required URL format using HTTPS.packages/web/config/wallet-registry.ts (1)
339-364: LGTM! Galaxy Station extension wallet properly configured.The extension wallet configuration follows best practices with proper chain support verification and secure URLs.
|
Just wondering when someone will have time to review this and merge please? |
1 participant
What is the purpose of the change:
Add support for Galaxy Station extension and mobile