Skip to content

fix: iavl pruning issue move onto next version if stuck#9334

Merged
PaddyMc merged 2 commits intomainfrom
fix/bump-iavl-to-fix-pruning
Mar 26, 2025
Merged

fix: iavl pruning issue move onto next version if stuck#9334
PaddyMc merged 2 commits intomainfrom
fix/bump-iavl-to-fix-pruning

Conversation

@PaddyMc
Copy link
Collaborator

@PaddyMc PaddyMc commented Mar 26, 2025

@PaddyMc PaddyMc added the V:state/compatible/backport State machine compatible PR, should be backported label Mar 26, 2025
@github-actions
Copy link
Contributor

Important Notice

This PR modifies an in-repo Go module. It is one of:

  • osmomath
  • osmoutils
  • x/ibc-hooks
  • x/epochs

The dependent Go modules, especially the root one, will have to be
updated to reflect the changes. Failing to do so might cause e2e to fail.

Please follow the instructions below:

  1. Open https://github.com/osmosis-labs/osmosis/actions/workflows/go-mod-auto-bump.yml
  2. Provide the current branch name
  3. On success, confirm if an automated commit corretly updated the go.mod and go.sum files

Please let us know if you need any help.

@PaddyMc PaddyMc added A:backport/v28.x backport patches to v28.x branch A:backport/v29.x backport patches to v8.x branch labels Mar 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 26, 2025

Walkthrough

The update modifies the CHANGELOG.md file by adding a new version entry and updating an existing one. A new version section (v28.0.6) is added that documents a bug fix addressing the IAVL pruning issue. Additionally, the entry for version v28.0.5 is updated to include the previously omitted CosmWasm Pool raw state query feature. The structure and order of the historical entries remain maintained.

Changes

File Change Summary
CHANGELOG.md - Added new version v28.0.6 with bug fix for IAVL pruning issue (#9334)
- Updated v28.0.5 to include the CosmWasm Pool raw state query feature (#9006)

Possibly related PRs

Suggested labels

V:state/breaking, A:no-changelog

Suggested reviewers

  • nicolaslara
  • czarcas7ic
  • deividaspetraitis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
CHANGELOG.md (2)

57-60: New Version Block for v28.0.6 Added
A new version section for v28.0.6 has been introduced to document the IAVL pruning issue fix (PR #9334). Please verify that the placement (as the most recent version) and formatting match the established changelog style. Consider whether the wording clearly explains that the system now moves on to the next version if it gets stuck during pruning.


60-64: v28.0.5 Section Updated
The entry for v28.0.5 now includes the CosmWasm Pool raw state query feature (PR #9006), in addition to the existing bump for ibc-go (PR #9050). Please check that these entries are correctly grouped under the "State Compatible" category and that the updates conform to the overall changelog format.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bad5682 and e85c196.

⛔ Files ignored due to path filters (4)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
  • osmoutils/go.mod is excluded by !**/*.mod
  • osmoutils/go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: go (01)
  • GitHub Check: go (02)
  • GitHub Check: go (03)
  • GitHub Check: go (00)
  • GitHub Check: e2e
  • GitHub Check: Run golangci-lint
  • GitHub Check: Summary

@PaddyMc PaddyMc merged commit 45d3e29 into main Mar 26, 2025
1 check passed
@PaddyMc PaddyMc deleted the fix/bump-iavl-to-fix-pruning branch March 26, 2025 21:25
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
* fix: iavl pruning issue move onto next version if stuck

* chore: add CHANGELOG.md

(cherry picked from commit 45d3e29)

# Conflicts:
#	go.sum
#	osmoutils/go.mod
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
* fix: iavl pruning issue move onto next version if stuck

* chore: add CHANGELOG.md

(cherry picked from commit 45d3e29)

# Conflicts:
#	osmoutils/go.mod
PaddyMc added a commit that referenced this pull request Mar 26, 2025
…) (#9335)

* fix: iavl pruning issue move onto next version if stuck (#9334)

* fix: iavl pruning issue move onto next version if stuck

* chore: add CHANGELOG.md

(cherry picked from commit 45d3e29)

# Conflicts:
#	go.sum
#	osmoutils/go.mod

* fix: merge commit

---------

Co-authored-by: PaddyMc <paddymchale@hotmail.com>
PaddyMc added a commit that referenced this pull request Mar 26, 2025
…) (#9336)

* fix: iavl pruning issue move onto next version if stuck (#9334)

* fix: iavl pruning issue move onto next version if stuck

* chore: add CHANGELOG.md

(cherry picked from commit 45d3e29)

# Conflicts:
#	osmoutils/go.mod

* fix: merge commit

---------

Co-authored-by: PaddyMc <paddymchale@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:backport/v28.x backport patches to v28.x branch A:backport/v29.x backport patches to v8.x branch V:state/compatible/backport State machine compatible PR, should be backported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants