Merged
Conversation
Maybe different name?
There was a problem hiding this comment.
Pull Request Overview
This PR adds a command-line interface (CLI) for the Korean romanizer package to enable users to romanize Korean text directly from the terminal.
- Adds a new CLI module with argument parsing for Korean text input
- Configures setup.py to expose the CLI as a console script named 'kroman'
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Adds console script entry point for the CLI |
| korean_romanizer/cli.py | Implements the main CLI functionality with argument parsing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
osori
approved these changes
Aug 26, 2025
Owner
osori
left a comment
osori
left a comment
There was a problem hiding this comment.
👏 This is a nice addition -- thanks for contributing!
| ], | ||
| entry_points={ | ||
| 'console_scripts': [ | ||
| 'kroman=korean_romanizer.cli:main', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #27