Conversation
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Blast545
approved these changes
Apr 25, 2025
Contributor
Blast545
left a comment
Blast545
left a comment
There was a problem hiding this comment.
Looks reasonable to me, I left some comments for a couple of things that caught my attention. We should be checking that the quoting changes don't break our reports.
Tagging @nuclearsandwich to give an extra set of Ruby eyes.
| optparser.parse!(ARGV) | ||
| options[:exclude] = Set.new() if options[:exclude].nil? | ||
| options[:report_name] = "buildfarm-report_#{DateTime.now.strftime("%Y-%m-%d_%H-%M")}.json" if options[:report_name].nil? | ||
| options[:exclude] = Set.new if options[:exclude].nil? |
Contributor
There was a problem hiding this comment.
Removing the parenthesis in this new() looks odd to me, is this expected?
Comment on lines
+82
to
+83
| if !tr['age'].to_i.nil? && (tr['age'].to_i >= CONSECUTIVE_THRESHOLD || tr['age'].to_i == WARNING_AGE_CONSTANT) | ||
| next |
Contributor
There was a problem hiding this comment.
Is this expected ruby syntax? It seems more "ruby" to me as it was before with the next if, for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says. This PR is only applying formatting with rubocop