Open
Conversation
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
marcoag
requested changes
Oct 10, 2022
Member
|
Added a few small comments, but before digging further it teems that the first part of the C++ adapter is just a copy/paste of the header file documentation. There's no need to duplicate documentation in two places, so we better leave that in the header file and just add a reference at the beginning of the tutorial. |
Co-authored-by: Marco A. Gutierrez <marco@openrobotics.org> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
xiyuoh
requested changes
Oct 14, 2022
xiyuoh
requested changes
Oct 14, 2022
xiyuoh
requested changes
Oct 14, 2022
xiyuoh
approved these changes
Oct 14, 2022
Co-authored-by: Xiyu <ohxiyu@gmail.com> Co-authored-by: Marco A. Gutierrez <marco@openrobotics.org> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com> Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Co-authored-by: Xiyu <ohxiyu@gmail.com> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com> Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Co-authored-by: Marco A. Gutierrez <marco@openrobotics.org> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com> Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Co-authored-by: Xiyu <ohxiyu@gmail.com> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com> Signed-off-by: Dev Manek <manekdev2001@gmail.com>
Co-authored-by: Xiyu <ohxiyu@gmail.com> Signed-off-by: Dev Manek <58616961+thedevmanek@users.noreply.github.com> Signed-off-by: Dev Manek <manekdev2001@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds C++ tutorial for the Fleet Adapter and solves the following discussions
solved discussions/184
solved discussions/185
solved discussions/180
solved discussions/145