bmp: correctly encode path identifier in NLRI when needed #2572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FSM has the right decoding options. First, we change the `marshallingOptions` field to a slice instead of a single option for consistency with the remaining of the code (`Serialize()` and `Parse*()` accepts several options). This is not really needed as we only initialize a single option or none, but I suppose this may matter in the future. Then, we pass the decoding options to the `watchUpdateEvent` struct. From my understanding, this is the only one needing it. When transmitting the local RIB, we don't need to encode paths with AddPath. And when mirroring routes, the routes are already encoded. I am however unable to correctly pass the decoding options in the post-policy case. I don't see an obvious way to access the FSM in this case.
vincentbernat
force-pushed
the
fix/add-path-bmp
branch
from
b6d3960 to
0f273a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FSM has the right decoding options. First, we change the
marshallingOptionsfield to a slice instead of a single option forconsistency with the remaining of the code (
Serialize()andParse*()accepts several options). This is not really needed as weonly initialize a single option or none, but I suppose this may matter
in the future.
Then, we pass the decoding options to the
watchUpdateEventstruct.From my understanding, this is the only one needing it. When
transmitting the local RIB, we don't need to encode paths with
AddPath. And when mirroring routes, the routes are already encoded.
I am however unable to correctly pass the decoding options in the
post-policy case. I don't see an obvious way to access the FSM in this
case.