Skip to content

Conversation

@nnobelis
Copy link
Member

@nnobelis nnobelis commented Nov 3, 2025

This is a fixup for b1d627f.

@nnobelis nnobelis requested a review from a team as a code owner November 3, 2025 13:40
@sschuberth sschuberth enabled auto-merge (rebase) November 3, 2025 13:44
@sschuberth sschuberth requested a review from a team November 3, 2025 13:48
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.42%. Comparing base (21ba6f9) to head (3556d79).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11041   +/-   ##
=========================================
  Coverage     57.42%   57.42%           
  Complexity     1703     1703           
=========================================
  Files           346      346           
  Lines         12835    12835           
  Branches       1215     1215           
=========================================
  Hits           7370     7370           
  Misses         4998     4998           
  Partials        467      467           
Flag Coverage Δ
funTest-external-tools 13.50% <ø> (ø)
funTest-no-external-tools 31.20% <ø> (ø)
test-ubuntu-24.04 42.35% <ø> (ø)
test-windows-2025 42.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nnobelis nnobelis force-pushed the nnobelis/snippet_choice_fixes branch from b12d31f to 845aa24 Compare November 3, 2025 14:19
@nnobelis nnobelis requested a review from sschuberth November 3, 2025 14:20
@nnobelis nnobelis force-pushed the nnobelis/snippet_choice_fixes branch from 845aa24 to 3556d79 Compare November 5, 2025 08:08
@nnobelis
Copy link
Member Author

nnobelis commented Nov 5, 2025

@sschuberth the failure seems to be test flakiness.

If this is the case, can I get an approval ?

@sschuberth
Copy link
Member

@sschuberth the failure seems to be test flakiness.

If this is the case, can I get an approval ?

Please just try retriggering individual tests (without force-pushing the whole branch). I've done this now for you.

But you need to find someone for a review still. I don't have time to immerse into FossID specific stuff today.

@sschuberth sschuberth merged commit c871bbf into oss-review-toolkit:main Nov 5, 2025
32 of 33 checks passed
@nnobelis nnobelis deleted the nnobelis/snippet_choice_fixes branch November 5, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants