fix(fossid): Don't create issue for zero pending identifications

[wkl3nk]

Don't create an issue about pending identifications in FossID if actually no pending identifications exist. This bug prevents the use of configuration option treatPendingIdentificationsAsError, as it reports an issue with severity ERROR even if there are zero pending identifications.

[nnobelis]

I will clarify how this impact us and review your PR.

[nnobelis]

After discussion with the team, we found out that removing the issue when there is no pending file would be too much of a change for our users: for instance, when looking at the WA reports, they would not know that FossId has run and found no file pending identification.

My suggestion is that you rather fix the logic when treatPendingIdentificationsAsError is set: if the pending file count is 0, then the issue should not have its severity raised to ERROR.

What do you think ?

[fviernau]

After discussion with the team, we found out that removing the issue when there is no pending file

Mind sharing which kind of "report" the users are looking at?

[nnobelis]

Mind sharing which kind of "report" the users are looking at?

As written in my message, the WebApp report.

[MarcelBochtler]

for instance, when looking at the WA reports, they would not know that FossId has run and found no file pending identification.

Would it be an option to show the information that FossID was being used in the new "metadata" view added in: #11326 ?
Having a "dummy issue" to show this information seems wrong.

[fviernau]

Would it be an option to show the information that FossID was being used in the new "metadata" view added in: #11326 ?
Having a "dummy issue" to show this information seems wrong.

I also think this PR is good. Creating issues for non-issues seems odd and not consistent.

Note: There is just this new #11358 which seems to show for each package the details of the scanner used. Would this be a good enough replacement for you @nnobelis ?

[nnobelis]

Having a "dummy issue" to show this information seems wrong.

I think you are all influenced by the term "issue". Till now, FossId pending file numbers were always returned with a issue with severity HINT. Is such an issue really an issue ? I don't think so, this is more an informative message than anything else.

Regarding the suggestions of @MarcelBochtler and @sschuberth :
@hanna-modica What is your opinion on this ? Is is a good enough replacement to having an issue with 0 pending files ?

[sschuberth]

Regarding the suggestions of @MarcelBochtler and @sschuberth :

I didn't suggest anything 😅 I guess you mean @fviernau.

[hanna-modica]

@nnobelis, from my perspective it is enough to have the information, that FossID was used successfully. I do not really require a further hint.