-
Notifications
You must be signed in to change notification settings - Fork 373
Add the scope includes #11405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nnobelis
wants to merge
6
commits into
oss-review-toolkit:main
Choose a base branch
from
boschglobal:nnobelis/scope_includes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add the scope includes #11405
nnobelis
wants to merge
6
commits into
oss-review-toolkit:main
from
boschglobal:nnobelis/scope_includes
+468
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
Add model classes for scope includes. Scope includes can be used to mark scopes matched by a glob pattern as included. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11405 +/- ##
============================================
+ Coverage 57.78% 57.83% +0.05%
- Complexity 1713 1720 +7
============================================
Files 347 349 +2
Lines 12904 12920 +16
Branches 1238 1240 +2
============================================
+ Hits 7456 7472 +16
Misses 5000 5000
Partials 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
…ies` Package managers that honor the scope excludes can thus be adapted to also honor the scope includes. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
17d3a2c to
2d5c2c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
Note: there is some usage of
isScopeExcludedin theDependencyGraphConverter: should they be also changed to use the newisScopeExcludedfunction ?Note2: this PR is point three of #10347 (comment).