-
Notifications
You must be signed in to change notification settings - Fork 373
Version utility improvements #11411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version utility improvements #11411
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
aaaa22b
style(model): Add a blank line after the header
sschuberth 93c310a
feat(model): Support Ivy's "Sub Revision Matcher" syntax explicitly
sschuberth cc80cc8
refactor(model): Simplify the code to get version ranges
sschuberth 03a3721
test(model): Add a direct test for Ivy "Sub Revision Matcher" syntax
sschuberth 38094e2
refactor(model): Rename `isVersionRange()` to `hasIvyVersionRange()`
sschuberth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| /* | ||
| * Copyright (C) 2026 The ORT Project Copyright Holders <https://github.com/oss-review-toolkit/ort/blob/main/NOTICE> | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * License-Filename: LICENSE | ||
| */ | ||
|
|
||
| package org.ossreviewtoolkit.model.utils | ||
|
|
||
| import io.kotest.core.spec.style.WordSpec | ||
| import io.kotest.matchers.collections.beEmpty | ||
| import io.kotest.matchers.should | ||
| import io.kotest.matchers.shouldBe | ||
|
|
||
| import org.ossreviewtoolkit.model.Identifier | ||
|
|
||
| import org.semver4j.range.Range | ||
|
|
||
| class VersionUtilsTest : WordSpec({ | ||
| "getIvyVersionRanges()" should { | ||
| "return an empty range list for pathological cases" { | ||
| "".getIvyVersionRanges().get() should beEmpty() | ||
| " ".getIvyVersionRanges().get() should beEmpty() | ||
| "foo".getIvyVersionRanges().get() should beEmpty() | ||
| "null".getIvyVersionRanges().get() should beEmpty() | ||
| } | ||
|
|
||
| "return an empty range list for invalid ranges" { | ||
| "[a,b]".getIvyVersionRanges().get() should beEmpty() | ||
| "[1,2))".getIvyVersionRanges().get() should beEmpty() | ||
| "[1.2.3,4.5.6".getIvyVersionRanges().get() should beEmpty() | ||
| "[1.2.3.4,5.6.7.8]".getIvyVersionRanges().get() should beEmpty() | ||
| } | ||
|
|
||
| "return an empty list for single versions" { | ||
| "2".getIvyVersionRanges().get() shouldBe listOf() | ||
| "2.0".getIvyVersionRanges().get() shouldBe listOf() | ||
| "2.0.0".getIvyVersionRanges().get() shouldBe listOf() | ||
| } | ||
|
|
||
| "return the correct range list for Ivy version ranges" { | ||
| "[1.2.3,4.5.6]".getIvyVersionRanges().get() shouldBe listOf( | ||
| listOf(Range("1.2.3", Range.RangeOperator.GTE), Range("4.5.6", Range.RangeOperator.LTE)) | ||
| ) | ||
|
|
||
| "[3.3.0,)".getIvyVersionRanges().get() shouldBe listOf( | ||
| listOf(Range("3.3.0", Range.RangeOperator.GTE)) | ||
| ) | ||
mnonnenmacher marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
|
|
||
| "isApplicableIvyVersion()" should { | ||
| "support 'Sub Revision Matcher' syntax" { | ||
| with(Identifier(":::1.0.+")) { | ||
| isApplicableIvyVersion(Identifier(":::1.0.1")) shouldBe true | ||
| isApplicableIvyVersion(Identifier(":::1.0.a")) shouldBe true | ||
| isApplicableIvyVersion(Identifier(":::1.0.1.0")) shouldBe true | ||
| } | ||
|
|
||
| with(Identifier(":::1.1+")) { | ||
| isApplicableIvyVersion(Identifier(":::1.1")) shouldBe true | ||
| isApplicableIvyVersion(Identifier(":::1.1.5")) shouldBe true | ||
| isApplicableIvyVersion(Identifier(":::1.10")) shouldBe true | ||
| } | ||
| } | ||
| } | ||
| }) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.