Skip to content

fix: Follow redirects during provenance check #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
losmateusz1 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Follow redirects during provenance check #11412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0235a10
fix(Provenance Resolver): Fall back to GET while checking artifact ex…
losmateusz1 Feb 10, 2026
351c341
fix(Provenance Resolver): Also try to download artifacts on 302 respo…
losmateusz1 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions scanner/src/main/kotlin/provenance/PackageProvenanceResolver.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,13 @@ class DefaultPackageProvenanceResolver(
}
}

// Try a cheap HEAD request to probe for the artifact first, and only fall back to a GET request on failure.
val responseCode = requestSourceArtifact(pkg, "HEAD").takeUnless { it == HttpURLConnection.HTTP_BAD_METHOD }
// Try a cheap HEAD request to probe for the artifact first, and fall back to a GET request when necessary.
// Some artifact are behind redirected urls, in case of 404 we need to fall back to GET to verify that.
val responseCode = requestSourceArtifact(pkg, "HEAD")
.takeUnless { it == HttpURLConnection.HTTP_BAD_METHOD || it == HttpURLConnection.HTTP_NOT_FOUND }
?: requestSourceArtifact(pkg, "GET")

if (responseCode == HttpURLConnection.HTTP_OK) {
if (responseCode == HttpURLConnection.HTTP_OK || responseCode == HttpURLConnection.HTTP_MOVED_TEMP) {
val artifactProvenance = ArtifactProvenance(pkg.sourceArtifact)
storage.writeProvenance(pkg.id, pkg.sourceArtifact, ResolvedArtifactProvenance(artifactProvenance))
return artifactProvenance
Expand Down
Loading