fix: Add authorization interceptor to okHttpClientHelper #11413
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Los <mateusz.los@extern.wenovate.de>
sschuberth
requested changes
Feb 10, 2026
Comment on lines
+130
to
+131
| if (request.header(AUTHORIZATION_HEADER) == null) { | ||
| val credentials = requestPasswordAuthentication(request.url.toUri()) |
Member
There was a problem hiding this comment.
If I'm not mistaken, this will try to authenticate any unauthenticated request, by looking up whether password authentication has been configured for the URL. This would add an overhead to any unauthenticated request, which I believe is not feasible.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11413 +/- ##
=========================================
Coverage 57.78% 57.78%
Complexity 1713 1713
=========================================
Files 347 347
Lines 12904 12904
Branches 1238 1238
=========================================
Hits 7456 7456
Misses 5000 5000
Partials 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.