Add issues from advisor providers to AdvisorRun#11536
Open
lamppu wants to merge 6 commits intooss-review-toolkit:mainfrom
Open
Add issues from advisor providers to AdvisorRun#11536lamppu wants to merge 6 commits intooss-review-toolkit:mainfrom
lamppu wants to merge 6 commits intooss-review-toolkit:mainfrom
Conversation
lamppu
requested review from
a team,
MarcelBochtler,
oheger-bosch and
tsteenbe
as code owners
fviernau
reviewed
Mar 5, 2026
| key: webAppOrtIssue.key, | ||
| message: webAppOrtIssue.message, | ||
| packageId: webAppOrtIssue.package.id, | ||
| packageId: webAppOrtIssue.package?.id, |
Member
There was a problem hiding this comment.
In other places UUI the code sometimes says || null. Would this make sense to append that here too?
Contributor
Author
There was a problem hiding this comment.
Actually now that I looked into it more, I noticed that the sorting doesn't work for undefined/null, so I used the packageName field instead, which resolves to an empty string in case of a missing package.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11536 +/- ##
=========================================
Coverage 57.97% 57.97%
Complexity 1730 1730
=========================================
Files 349 349
Lines 12993 12993
Branches 1263 1263
=========================================
Hits 7533 7533
Misses 4995 4995
Partials 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The `webAppOrtIssue` package field can be undefined, so use the `packageName` field instead, which resolves to an empty string in case of a missing package. This prevents an "Uncaught TypeError: can't access property "id", $.package is undefined" error being thrown, and ensures that the comparison in the sorting function for the Package column also works. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
If the creation of a provider fails, or the querying of results for a specific provider completely fails, collect the issue, and allow other providers to still be run. Resolves oss-review-toolkit#11460. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
Add a function in the `OrtResult` data class to get all the advisor provider issues, as these are not mapped to an identifier, and therefore cannot be added to the `getAdvisorIssues` result map. Also add the advisor provider issues in the `getOpenIssues` output. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
Add the provider issues that aren't part of the advisor results to the `EvaluatedModel` issues. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
Add provider issues to the advisor issues table. As these issues are not mapped to an identifier, refactor the table to allow issues without an identifier. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.org>
lamppu
force-pushed
the
11460-advisor-provider-issues
branch
from
2569968 to
cc7f18c
Compare
sschuberth
reviewed
Mar 5, 2026
| /** | ||
| * The [Issue]s that occurred while preparing and querying advisor providers for this run. | ||
| */ | ||
| val providerIssues: Set<Issue> = emptySet(), |
Member
There was a problem hiding this comment.
In ScannerRun, we call this just issues. What's the reason to name it differently here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the individual commits for details.