Open
Conversation
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This allows for an upcoming fix. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Make properties that are in any case set `lateinit` and reorder them for readability. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Member
Author
|
FYI @maennchen, see the last commit. |
maennchen
approved these changes
Mar 5, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11538 +/- ##
=========================================
Coverage 57.97% 57.98%
Complexity 1730 1730
=========================================
Files 349 349
Lines 12993 12992 -1
Branches 1263 1262 -1
=========================================
Hits 7533 7533
Misses 4995 4995
+ Partials 465 464 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This prematurely adds support for the upcoming PURL type for generic Git repositories [1] to avoid an empty PURL being created from the `id` if the VCS host cannot be determined. [1]: package-url/purl-spec#823 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This reverts commit 4af9208. It is not needed anymore as Pub SDK packages are being filtered out before PURL construction, and Carthage supports non-empty PURLs for generic Git URLs now. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.