Skip to content

fix(apig): porting the serverless fix in https://github.com/serverles… #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joseph-so wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(apig): porting the serverless fix in https://github.com/serverles… #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
740cf02
fix(apig): porting the serverless fix in https://github.com/serverles…
joseph-so Jan 5, 2026
17cec29
reverse the change based on feedback
joseph-so Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/plugins/aws/custom-resources/resources/api-gateway-cloud-watch-role/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
'use strict';

/**
* IMPORTANT: This file is cached, so when you test changes made to this file,
* make sure you delete the .serverless directory, and un-memoize the packaging code.
* For more info search for the "utils/ensure-artifact.js" file in the codebase.
*/

const { wait, MAX_AWS_REQUEST_TRY } = require('../utils');
const { getEnvironment, handlerWrapper } = require('../utils');
const {
Expand Down Expand Up @@ -52,7 +58,10 @@ async function create(event, context) {
return (await iam.send(new ListAttachedRolePoliciesCommand({ RoleName: roleName })))
.AttachedPolicies;
} catch (error) {
if (error.code === 'NoSuchEntity') {
if (
error.code === 'NoSuchEntity' ||
error.message.includes('cannot be found')
) {
// Role doesn't exist yet, create;
await iam.send(
new CreateRoleCommand({
Expand Down