Merged
Conversation
and rearranged the HTML structure to use the new JS.
3 tasks
jacksayshi
reviewed
May 2, 2025
Collaborator
jacksayshi
left a comment
jacksayshi
left a comment
There was a problem hiding this comment.
Hello @tluke900 Thank you for working on this issue.
navigation.js logic looks good. The buttons are working as required. Functional only when subbone(s) are selected. We can merge these changes. Thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #112
1. What was Changed
New folders created in order to separate JS functions from HTML code and HTML updated to use it.
2. Why it was Changed
JavaScript was adjusted to match more standard practices, new functions created to more easily scroll through sub-bone components instead of using the drop downs for ease of use.
3. How it was Changed
JS functions separated into their own folders, main.js created to facilitate their use. The next and prev buttons are able to dynamically load each time a new "bone" is selected, changing the sub bones displayed.
A more technical description of the changes that were made. This is additional information that we will be using when reviewing code changes, so it's a great place for you to share some of your thoughts about how you changed the code. Detail the methods or techniques used to implement the changes. You can also mention any challenges you faced or alternatives you considered.