Merged
Conversation
…y. Same functionality should still apply and also moved sidebar into new directory that holds all relevant js files.
jacksayshi
requested changes
May 2, 2025
Collaborator
There was a problem hiding this comment.
Thank you @Balijah for working on the issue. Here are couple of things :
-
In js directory, please make sure the file names are 'description.js' and 'dropdowns.js' (Because of the typo the functionality is not available in webpage)
-
Also, the original sidebar logic contained its own DOM it makes it hard to modularize. Please make this into an export function and import this in main.js so that we can maintain the sidebar and its functionality.
Other modules are well modularized. Thank you again for working on this. Please work on these changes so that we can close this issue
…on.js and dropdowns.js, changed sidebar.js and main.js so that sidebar.js can be exported and main.js can import. Full modularization should be acheived.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #113
Description
Addresses Issue #113 where we must modularize the js script in bonset.html. This includes breaking it up into separate files holding their own functionalities providing clear and concise structure.
1. What was Changed
bonset.html file was changed. The script was removed and split into separate files. A new directory named "js" was created which stores all the relevant js functions. Also "sidebar.js" was moved into the new js directory.
2. Why it was Changed
This change was made in order to follow proper software design principles. We modularized the functions to provide clear structure which allows for help in debugging and future extensions.
3. How it was Changed
This change was made by breaking the script within boneset.html into its own separate files that each hold their own functionality. All relevant files are kept in "js" directory under "templates" (check screenshot below"
4. Screenshots (if applicable)