Add support for PostgreSQL18 #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinyaaa
force-pushed
the
add-support-pg18
branch
from
5e9b800 to
7d763f7
Compare
shinyaaa
force-pushed
the
add-support-pg18
branch
from
7d763f7 to
d532226
Compare
shinyaaa
force-pushed
the
add-support-pg18
branch
from
554a6d8 to
845b4b7
Compare
zwyan0
reviewed
Jan 5, 2026
| #endif | ||
| #endif | ||
|
|
||
| #ifdef HAVE_LONG_INT_64 |
Contributor
There was a problem hiding this comment.
pg17まだ#ifdef HAVE_LONG_INT_64利用しているようですね
https://github.com/postgres/postgres/blob/498b163a161e2a545a327ae5604682d5e00f3dfa/src/include/c.h#L520
こちらの修正を見ると、正しいように見えます
Use <stdint.h> and <inttypes.h> for c.h integers.
分岐とか入れたほうがよさそうですかね？
Contributor
Author
There was a problem hiding this comment.
SIZEOF_LONG is defined at ./configure, regardless of the PostgreSQL version. Therefore, it is safe to use #if SIZEOF_LONG == 8 in any version of PostgreSQL.
zwyan0
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added support for PostgreSQL 18.
Please see the individual commit messages for details.
Closes #172