Conversation
rjuju
force-pushed
the
ci
branch
4 times, most recently
from
e223a34 to
d6a0963
Compare
Closed
Run the regression tests on PG 12 .. 16 Use the actual associated branch rather than the project default branch
On postgres 15 and below, pgsptokentype is defined to void rather than an actual enum, so a lot of functions don't return anything. But an empty JSONACTION_RETURN_SUCCESS define doesn't exit the function as it would with pg16+ definition, which leads to bogus behavior. To fix, simply define JSONACTION_RETURN_SUCCESS to "return" on pg 15 and below.
Numeric with a base, like 0b1 or 0x1 are not supported by the parser before pg16, so we cannot test those in the regression tests for a test run against all major versions.
rjuju
changed the title
This variable is unused on pg13 and below, which leads to spurious warnings. Since that variable is only used once and since the saved value is never overwritten, simply use the target value.
This version is now EOF, and one of the test is checking incremental sorts, which are only supported on pg13 and above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.