* insert into db true NULLs instead string "NULL"#2105
Open
AdUser wants to merge 1 commit intoossec:masterfrom
Open
* insert into db true NULLs instead string "NULL"#2105AdUser wants to merge 1 commit intoossec:masterfrom
AdUser wants to merge 1 commit intoossec:masterfrom
Conversation
Author
|
P.S. This patch tested with postgresql database about ten months, and have no issues in my ossec setup, but feel free to do more testing if you consider so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes insertion of srcip/dstip alert fields to database table from "NULL" (varchar string) value to true sql NULLs.
it takes less space in table and add ability to use IS NULL/NOT NULL/... sql expressions instead slower string comparision.