Open
Conversation
The function returns if the type is 'READ' so the else statment was not really necessary.
The retry logic was a bit ugly. Much of it looked like a poor mans exponential backoff so stole a function from Jordan Sissel and modified it slightly to improve the implementation and reduce code duplication: https://github.com/jordansissel/experiments/blob/master/randomcode/exponential-backoff.c Many of the waits seemed arbitrary and unfortunately, do not line up exactly when using an exponential backoff. These changes will retry things more often and could increase the overall time in which things wait before giving up on retrying but only by 5 seconds at the most. The biggest add in time (5 seconds) is in SendMSG() which is used quite heavily throughout the code so the additional few seconds could have some impact but it is difficult to say how much. There hopefully should be none but it's worth noting. Most of the code will actually call SendMSG() twice should the first call not result in the message being sent which means most things are able to wait a decently long time in order to get their message sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.