Skip to content

ci: ensure that databases table in docs/schema.md is valid #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2025
Merged

ci: ensure that databases table in docs/schema.md is valid #395

merged 4 commits into from
Aug 11, 2025

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 11, 2025

This should catch mistakes like #393

@G-Rath G-Rath marked this pull request as draft August 11, 2025 00:14
another-rex
another-rex approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I took a quick look for markdown validators and didn't find anything, turns out just building it yourself is the way to go.

@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 11, 2025

yeah by coincidence I recently explored HTMLParser for handling extracting credits for Drupal advisories, as the upstream uses a rich text w/ li elements so when I saw your PR here I was like "hey I know exactly how to catch that!"

I'm just improving the output a little, and then it should be good to land

@G-Rath G-Rath force-pushed the add-table-validator branch from 0ee70ca to 1d7c540 Compare August 11, 2025 00:28
@G-Rath
Copy link
Contributor Author

G-Rath commented Aug 11, 2025

Perfect 😄
image

@G-Rath G-Rath force-pushed the add-table-validator branch from 1d7c540 to ff36218 Compare August 11, 2025 00:29
@G-Rath G-Rath marked this pull request as ready for review August 11, 2025 00:29
@another-rex another-rex merged commit 3418df2 into ossf:main Aug 11, 2025
6 checks passed
@G-Rath G-Rath deleted the add-table-validator branch August 11, 2025 01:44
jess-lowe pushed a commit to jess-lowe/osv-schema that referenced this pull request Aug 27, 2025
@G-Rath @jess-lowe
ci: ensure that databases table in docs/schema.md is valid (ossf#395)
a972432 
This should catch mistakes like ossf#393

---------

Signed-off-by: Gareth Jones <[email protected]>
Signed-off-by: Jess Lowe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@another-rex another-rex another-rex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G-Rath @another-rex