🌱 migrate to golangci-lint v2

[spencerschrock]

What kind of change does this PR introduce?

linter update

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

We use v1 of golangci-lint and dont get any updates.
Fix the current linter violations which can be confusing to contributors (e.g. #4639 (comment))

What is the new behavior (if this is a feature change)?**

We migrate to using v2

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Please review one commit at a time, as I tried to break them up, hopefully makes it easier.

The first commit was made by running golangci-lint migrate and adding the comments back.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

[codecov]

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.32%. Comparing base (353ed60) to head (768475d).
⚠️ Report is 228 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4641      +/-   ##
==========================================
+ Coverage   66.80%   68.32%   +1.52%     
==========================================
  Files         230      249      +19     
  Lines       16602    18929    +2327     
==========================================
+ Hits        11091    12934    +1843     
- Misses       4808     5133     +325     
- Partials      703      862     +159     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity

[github-actions]

This pull request has been marked stale because it has been open for 10 days with no activity

[spencerschrock]

Rebased on top of main, with 2 new commits to fix new issues that popped up since this was initially submitted:
a81eb85
768475d

[spencerschrock]

/scdiff generate Maintained,Security-Policy,CII-Best-Practices,Branch-Protection,Dangerous-Workflow,CI-Tests,Binary-Artifacts,Packaging,Signed-Releases,Code-Review,License,Token-Permissions,SAST,Vulnerabilities,Dependency-Update-Tool,Pinned-Dependencies,Fuzzing

[github-actions]

Here's a link to the scdiff run