Skip to content

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Jul 23, 2025

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

feature

What is the current behavior?

Scorecard doesn't detect use of blocked_user name and email. These are values controlled by users and can be weaponized. I am not sure an email can be weaponized, but Scorecard detects these in other cases, so I am adding that too.

See details in https://docs.github.com/en/webhooks/webhook-events-and-payloads#org_block

What is the new behavior (if this is a feature change)?**

Scorecard detects use of blocked_user name and email.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

I have not found any examples of this in any open source project, but from what I can read from https://docs.github.com/en/webhooks/webhook-events-and-payloads, it is a field that can exist in events.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

Yes

Scorecard detects dangerous use of `blocked_user.name` and `blocked_user.email`

@AdamKorcz AdamKorcz requested a review from a team as a code owner July 23, 2025 21:26
@AdamKorcz AdamKorcz requested review from spencerschrock and raghavkaul and removed request for a team July 23, 2025 21:26
@AdamKorcz AdamKorcz temporarily deployed to integration-test July 23, 2025 21:26 — with GitHub Actions Inactive
@AdamKorcz AdamKorcz temporarily deployed to integration-test July 23, 2025 21:27 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.30%. Comparing base (353ed60) to head (0fb1c49).
⚠️ Report is 237 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4720      +/-   ##
==========================================
+ Coverage   66.80%   68.30%   +1.49%     
==========================================
  Files         230      249      +19     
  Lines       16602    18900    +2298     
==========================================
+ Hits        11091    12909    +1818     
- Misses       4808     5131     +323     
- Partials      703      860     +157     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AdamKorcz AdamKorcz marked this pull request as draft July 24, 2025 10:29
@AdamKorcz AdamKorcz marked this pull request as ready for review July 24, 2025 10:42
Copy link

github-actions bot commented Aug 4, 2025

This pull request has been marked stale because it has been open for 10 days with no activity

@github-actions github-actions bot added Stale and removed Stale labels Aug 4, 2025
Copy link

This pull request has been marked stale because it has been open for 10 days with no activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants