Skip to content

Conversation

jwagantall
Copy link
Contributor

@jwagantall jwagantall commented Aug 4, 2025

What kind of change does this PR introduce?

It adds a new project to the list.

What is the current behavior?

This project is not scanned as part of the cron

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)
    • N/A

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

NONE

Does this PR introduce a user-facing change?

NONE

@jwagantall jwagantall requested a review from a team as a code owner August 4, 2025 19:17
@jwagantall jwagantall requested review from spencerschrock and raghavkaul and removed request for a team August 4, 2025 19:17
@spencerschrock
Copy link
Member

@jwagantall jwagantall changed the title chore: Add Hiero's hiero-did-sdk-js repo to the cron 🌱 chore: Add Hiero's hiero-did-sdk-js repo to the cron Aug 4, 2025
@jwagantall jwagantall temporarily deployed to integration-test August 4, 2025 22:10 — with GitHub Actions Inactive
@spencerschrock
Copy link
Member

Please be sure to run make add-projects and commit the changes, as specified in the CONTRIBUTING.md for adding projects

Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.30%. Comparing base (353ed60) to head (6cefde6).
⚠️ Report is 225 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4743      +/-   ##
==========================================
+ Coverage   66.80%   68.30%   +1.49%     
==========================================
  Files         230      249      +19     
  Lines       16602    18929    +2327     
==========================================
+ Hits        11091    12929    +1838     
- Misses       4808     5137     +329     
- Partials      703      863     +160     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jwagantall jwagantall force-pushed the hiero-did-sdk-js branch 2 times, most recently from b60a0ac to 0ab7be3 Compare August 5, 2025 20:49
@jwagantall
Copy link
Contributor Author

Please be sure to run make add-projects and commit the changes, as specified in the CONTRIBUTING.md for adding projects

Thank you!.. sorry .. i fixed it now :) and rebase

Copy link

This pull request has been marked stale because it has been open for 10 days with no activity

@jwagantall
Copy link
Contributor Author

@spencerschrock, this is still needed, can we have a review please?

@github-actions github-actions bot removed the Stale label Aug 19, 2025
@jwagantall
Copy link
Contributor Author

@spencerschrock Can i please get another review?

@jwagantall jwagantall changed the title 🌱 chore: Add Hiero's hiero-did-sdk-js repo to the cron 🌱 chore: Add Hiero's hiero-did-sdk-js and hiero-hederium Aug 28, 2025
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spencerschrock Can i please get another review?

Been on vacation, slowly catching up now.

@spencerschrock spencerschrock merged commit fac845e into ossf:main Sep 3, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants