Merged
Conversation
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
c1e9c59 to
612cb8b
Compare
Member
Author
|
OK, fixed the merge conflict we discussed in the feb 18th meeting, PTAL |
funnelfiasco
approved these changes
Feb 18, 2025
Contributor
funnelfiasco
left a comment
There was a problem hiding this comment.
LGTM. I ran it through some general usage and everything worked as expected.
eddie-knight
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the baseline compiler code to separate the cli from the generation/loading logic. This allows us to extend the cli to support more use cases and makes the loader and generator easier to use.
In summary, this PR:
baseline.Loaderandbaseline.Generatorobjects that house the existing logic.The CLI itself has the same interface as before:
I'll follow up with PR with a validation command.
Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net