Add note on enabling RELRO for library dependencies #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Nyman <[email protected]>
|
|
||
| #### Additional considerations | ||
|
|
||
| To benefit from partial and full relro both the application executable and any libraries that are linked to the application must be built with the appropriate compiler options. If any non-RELRO libraries are loaded by `ld.so` they will prevent RELRO from being enabled for the applications. |
There was a problem hiding this comment.
For consistency, relro -> RELRO
There was a problem hiding this comment.
If ld.so loads any non-RELRO libraries, RELRO will be disabled for that application.
thomasnyman
force-pushed
the
relro_on_library_dependencies
branch
2 times, most recently
from
19d405a to
2704393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "additional considerations" section for the
-Wl,-z,relroand-Wl,-z,nowoptions section noting that shared libraries built without RELRO will prevent the application from benefitting from these hardening flags.