Skip to content

Conversation

myteron
Copy link
Contributor

@myteron myteron commented Oct 11, 2024

  • PyLint 6
  • Bandit 3
  • Pyre 1
  • flake8 0
  • Pysa 0

Some type hint related flaws are corrected as part of this PR

fixed wrong type hints in:
CWE-664/CWE-134/compliant01.py
CWE-664/CWE-843/compliant01.py
CWE-682/CWE-1335/01/compliant02.py
CWE-693/CWE-184/compliant01.py
CWE-693/CWE-184/noncompliant01.py

renamed CWE-664/CWE-502/compliant01.py to example as it does not represent compliance.

- PyLint 6
- Bandit 3
- Pyre 1
- flake8 0
- Pysa 0

Some type hint related flaws are corrected as part of this PR

fixed wrong type hints in:
CWE-664/CWE-134/compliant01.py
CWE-664/CWE-843/compliant01.py
CWE-682/CWE-1335/01/compliant02.py
CWE-693/CWE-184/compliant01.py
CWE-693/CWE-184/noncompliant01.py

renamed CWE-664/CWE-502/compliant01.py to example as it does not represent compliance.

Signed-off-by: Helge Wehder <[email protected]>
CWE-664/665/ removed example01.py as its just a code snippet

Signed-off-by: Helge Wehder <[email protected]>
Copy link

@barnabasdomozi barnabasdomozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I reviewed the PR.

The changes LGTM.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the proposal to move this code into documentation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly fixed the type annotation issue.

Copy link
Contributor

@BartyBoi1128 BartyBoi1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine! I approve them!

@myteron myteron merged commit 21937cb into ossf:main Oct 17, 2024
2 checks passed
@myteron myteron deleted the pySAST_findings branch October 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants